HeartSaVioR commented on code in PR #47574:
URL: https://github.com/apache/spark/pull/47574#discussion_r1733577154
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/state/StateDataSource.scala:
##########
@@ -52,30 +54,136 @@ class StateDataSource extends TableProvider with
DataSourceRegister {
override def shortName(): String = "statestore"
+ private var stateStoreMetadata: Option[Array[StateMetadataTableEntry]] = None
Review Comment:
I'm not sure making this instance as stateful is safe. I got to check some
data source implementations and all of them are stateless. (I couldn't check
everything so I'd say "most of".)
@cloud-fan Do you happen to know about the safeness of this? This isn't
quite clear from the interface contract in TableProvider and DataSourceRegister.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
