aokolnychyi commented on code in PR #47190: URL: https://github.com/apache/spark/pull/47190#discussion_r1710498011
########## sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/procedures/UnboundProcedure.java: ########## @@ -0,0 +1,44 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.connector.catalog.procedures; + +import org.apache.spark.annotation.Evolving; +import org.apache.spark.sql.types.StructType; + +/** + * A procedure that is not bound to input types. + * + * @since 4.1.0 + */ +@Evolving +public interface UnboundProcedure extends Procedure { + /** + * Binds this procedure to input types. + * <p> + * If the catalog supports procedure overloading, implementations are expected to pick the best + * matching version of the procedure. If procedure overloading is not supported, implementations + * can either validate if the input type is compatible while binding or delegate that to Spark. + * Regardless, Spark will always perform the final validation of the arguments and rearrange them + * as needed based on {@link BoundProcedure#parameters() parameters}. + * + * @param inputType the input type to bind + * @return the bound procedure best matching for the input type + * @throws UnsupportedOperationException if the input type is not supported (optional) + */ + BoundProcedure bind(StructType inputType); Review Comment: This is not possible because we don't know the mode of the parameters upfront. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
