MaxGekk commented on code in PR #47620:
URL: https://github.com/apache/spark/pull/47620#discussion_r1710983315
##########
common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationSupport.java:
##########
@@ -477,7 +477,7 @@ public static String genCode(final String string, final
String delimiter,
} else if (collation.supportsLowercaseEquality) {
return String.format(expr + "Lowercase(%s, %s, %s)", string,
delimiter, count);
} else {
- return String.format(expr + "ICU(%s, %s, %d, %s)", string, delimiter,
count, collationId);
+ return String.format(expr + "ICU(%s, %s, %s, %d)", string, delimiter,
count, collationId);
Review Comment:
Could you explain why you did that, please. PR description says only about
improving testing but this change is not about testing. That's confuses
slightly.
##########
common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationSupport.java:
##########
@@ -490,8 +490,7 @@ public static UTF8String execLowercase(final UTF8String
string, final UTF8String
}
public static UTF8String execICU(final UTF8String string, final UTF8String
delimiter,
final int count, final int collationId) {
- return CollationAwareUTF8String.subStringIndex(string, delimiter, count,
- collationId);
+ return CollationAwareUTF8String.subStringIndex(string, delimiter, count,
collationId);
Review Comment:
It is an unnecessary change. Does java style checker complain this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
