MaxGekk commented on code in PR #47620:
URL: https://github.com/apache/spark/pull/47620#discussion_r1711198264


##########
common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationSupport.java:
##########
@@ -477,7 +477,7 @@ public static String genCode(final String string, final 
String delimiter,
       } else if (collation.supportsLowercaseEquality) {
         return String.format(expr + "Lowercase(%s, %s, %s)", string, 
delimiter, count);
       } else {
-        return String.format(expr + "ICU(%s, %s, %d, %s)", string, delimiter, 
count, collationId);
+        return String.format(expr + "ICU(%s, %s, %s, %d)", string, delimiter, 
count, collationId);

Review Comment:
   Could you rebase this PR on the recent master than, please.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to