yaooqinn commented on code in PR #47684:
URL: https://github.com/apache/spark/pull/47684#discussion_r1711174739
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/V2SessionCatalog.scala:
##########
@@ -170,7 +170,8 @@ class V2SessionCatalog(catalog: SessionCatalog)
val storage =
DataSource.buildStorageFormatFromOptions(toOptions(tableProperties))
.copy(locationUri = location.map(CatalogUtils.stringToURI))
val isExternal = properties.containsKey(TableCatalog.PROP_EXTERNAL)
- val tableType = if (isExternal || location.isDefined) {
+ val isManagedLocation =
properties.containsKey(TableCatalog.PROP_IS_MANAGED_LOCATION)
Review Comment:
do we need to test if it is true or not?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
