cloud-fan commented on code in PR #47684:
URL: https://github.com/apache/spark/pull/47684#discussion_r1711548845
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/ShowCreateTableExec.scala:
##########
@@ -120,7 +120,7 @@ case class ShowCreateTableExec(
private def showTableLocation(table: Table, builder: StringBuilder): Unit = {
val isManagedOption =
Option(table.properties.get(TableCatalog.PROP_IS_MANAGED_LOCATION))
// Only generate LOCATION clause if it's not managed.
- if (isManagedOption.forall(_.equalsIgnoreCase("false"))) {
+ if (isManagedOption.isEmpty ||
!isManagedOption.get.equalsIgnoreCase("true")) {
Review Comment:
A small fix to match the document. `true` means effective, non `true` means
not effective.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
