HyukjinKwon opened a new pull request, #47702: URL: https://github.com/apache/spark/pull/47702
### What changes were proposed in this pull request? This PR embeds the configuration validation logic in scripts (added in https://github.com/apache/spark/pull/47402) to `SparkSubmitCommandBuilder` to be consistent. ### Why are the changes needed? To have the consistent one place that handles configurations. Those configuration validation at the script level was a temporary workaround that we should remove it away. ### Does this PR introduce _any_ user-facing change? No, refactoring. ### How was this patch tested? Manually tested: ``` ./bin/spark-shell --remote "local[*]" ... spark.range(10).show() ``` ``` ./sbin/start-connect-server.sh --wait ... ./bin/spark-shell --remote "sc://localhost" ... spark.range(10).show() ``` ``` ./bin/spark-shell --remote "local[*]" --conf spark.sql.ansi.enabled=false ... spark.conf.get("spark.sql.ansi.enabled") ``` ``` ./bin/spark-shell --remote "local[*]" --conf spark.sql.ansi.enabled=false --conf spark.abcabc=abc --conf spark.sql.debug=true ... spark.conf.get("spark.sql.debug") spark.conf.get("spark.sql.ansi.enabled") ``` ``` ./sbin/start-connect-server.sh --wait ... ./bin/spark-shell --remote "sc://localhost" --conf spark.sql.ansi.enabled=false --conf spark.abcabc=abc --conf spark.sql.debug=true ... spark.conf.get("spark.sql.debug") spark.conf.get("spark.sql.ansi.enabled") ``` ``` SPARK_REMOTE="sc://localhost" ./bin/spark-shell ... spark.range(1).collect() ``` ### Was this patch authored or co-authored using generative AI tooling? No. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
