HyukjinKwon commented on code in PR #47702:
URL: https://github.com/apache/spark/pull/47702#discussion_r1713191075
##########
bin/spark-shell:
##########
@@ -44,42 +44,11 @@ Scala REPL options, Spark Classic only:
# through spark.driver.extraClassPath is not automatically propagated.
SPARK_SUBMIT_OPTS="$SPARK_SUBMIT_OPTS -Dscala.usejavacp=true"
-# In order to start Spark Connect shell, we should identify if spark.remote
-# or --remote is set. Spark Connect does not support loading configurations
-# yet.
-connect_shell=false
-cur_arg="$0"
-for arg in "${@:1}"
-do
- # --conf spark.remote=... or -c spark.remote=...
- if [[ $cur_arg == "--conf" || $cur_arg == "-c" ]]; then
- if [[ $arg == "spark.remote"* ]]; then
- connect_shell=true
- fi
- fi
-
- # --conf=spark.remote=... or -c=spark.remote=...
- if [[ $arg == "--conf=spark.remote"* || $arg == "-c=spark.remote"* ]]; then
- connect_shell=true
- fi
-
- # --remote= or --remote
- if [[ $arg == "--remote"* ]]; then
- connect_shell=true
- fi
- cur_arg=$arg
-done
-
-if [ -n "${SPARK_REMOTE}" ]; then
- connect_shell=true
-fi
-
function main() {
- if $connect_shell; then
- export SPARK_SUBMIT_OPTS
- export SPARK_CONNECT_SHELL=1
- "${SPARK_HOME}"/bin/spark-submit --class
org.apache.spark.sql.application.ConnectRepl --name "Connect shell" "$@"
- elif $cygwin; then
+ export SPARK_SCALA_SHELL=1
Review Comment:
This will be removed with https://github.com/apache/spark/pull/47434
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
