Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/6546#issuecomment-107748117
> if this is just for testing, how about we put it into a SparkListener in
the tests instead, and avoid changing JobProgressListener? You could put it
into a common listener trait that could be used for both tests. The listener
would just count how many times onExecutorAdded / onExecutorRemoved were called
and would have a similar waitUntilExecutorsUp method.
The problem of a new SparkListener is "adding an Executor" may happen
before "adding the new SparkListener to SparkContext". So the new SparkListener
may miss some messages before adding itself to SparkContext.
`JobProgressListener` is added as early as possible so that it won't miss any
message.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
