Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/6546#discussion_r31672318
--- Diff:
core/src/test/scala/org/apache/spark/ExternalShuffleServiceSuite.scala ---
@@ -55,6 +55,14 @@ class ExternalShuffleServiceSuite extends ShuffleSuite
with BeforeAndAfterAll {
sc.env.blockManager.externalShuffleServiceEnabled should equal(true)
sc.env.blockManager.shuffleClient.getClass should
equal(classOf[ExternalShuffleClient])
+ // In a slow machine, one slave may register hundreds of milliseconds
ahead of the other one.
+ // If we don't wait for all salves, it's possible that only one
executor runs all jobs. Then
+ // all shuffle blocks will be in this executor,
ShuffleBlockFetcherIterator will directly fetch
+ // local blocks from the local BlockManager and won't send requests to
ExternalShuffleService.
+ // In this case, we won't receive FetchFailed. And it will make this
test fail.
+ // Therefore, we should wait until all salves are up
--- End diff --
salves again
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
