dongjoon-hyun commented on code in PR #80:
URL:
https://github.com/apache/spark-kubernetes-operator/pull/80#discussion_r1724340409
##########
spark-submission-worker/src/main/java/org/apache/spark/k8s/operator/SparkClusterResourceSpec.java:
##########
@@ -45,20 +48,38 @@ public SparkClusterResourceSpec(SparkCluster cluster,
SparkConf conf) {
String namespace = conf.get(Config.KUBERNETES_NAMESPACE().key(),
clusterNamespace);
String image = conf.get(Config.CONTAINER_IMAGE().key(),
"spark:4.0.0-preview1");
ClusterSpec spec = cluster.getSpec();
- masterService = buildMasterService(clusterName, namespace);
- masterStatefulSet = buildMasterStatefulSet(clusterName, namespace, image);
+ masterService =
+ buildMasterService(
+ clusterName,
+ namespace,
+ cluster.getSpec().getMasterSpec().getMasterServiceMetadata(),
Review Comment:
nit. Just a coding style comment. It's not good to repeat the same thing
multiple time. For example, we already have `spec` as a local variable. So,
let's not add a new like this, `cluster.getSpec().getMasterSpec()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
