dongjoon-hyun commented on code in PR #80:
URL:
https://github.com/apache/spark-kubernetes-operator/pull/80#discussion_r1724349181
##########
spark-operator-api/src/main/java/org/apache/spark/k8s/operator/spec/ClusterInstanceConfig.java:
##########
@@ -0,0 +1,19 @@
+package org.apache.spark.k8s.operator.spec;
+
+import com.fasterxml.jackson.annotation.JsonInclude;
+import io.fabric8.generator.annotation.Required;
+import lombok.AllArgsConstructor;
+import lombok.Builder;
+import lombok.Data;
+import lombok.NoArgsConstructor;
+
+@Data
+@NoArgsConstructor
+@AllArgsConstructor
+@Builder
+@JsonInclude(JsonInclude.Include.NON_NULL)
+public class ClusterInstanceConfig {
Review Comment:
I'd recommend to use `WorkerInstanceConfig` because we are not creating
multiple cluster instances.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
