uros-db commented on code in PR #47154:
URL: https://github.com/apache/spark/pull/47154#discussion_r1727042015
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Mode.scala:
##########
@@ -50,17 +50,19 @@ case class Mode(
override def inputTypes: Seq[AbstractDataType] = Seq(AnyDataType)
override def checkInputDataTypes(): TypeCheckResult = {
- if (UnsafeRowUtils.isBinaryStable(child.dataType) ||
child.dataType.isInstanceOf[StringType]) {
+ // TODO: SPARK-48700: Mode expression for map type with collated fields
Review Comment:
`SPARK-48700` is the current ticket (we sholdn't leave behind TODOs related
to the current tickets)
I created a new ticket for MapType:
https://issues.apache.org/jira/browse/SPARK-49358
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
