uros-db commented on code in PR #47154:
URL: https://github.com/apache/spark/pull/47154#discussion_r1723069923
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Mode.scala:
##########
@@ -86,6 +88,58 @@ case class Mode(
buffer
}
+ private def getCollationAwareBuffer(
+ childDataType: DataType,
+ buffer: OpenHashMap[AnyRef, Long]): Iterable[(AnyRef, Long)] = {
+ def groupAndReduceBuffer(groupingFunction: AnyRef => _): Iterable[(AnyRef,
Long)] = {
+ buffer.groupMapReduce(t =>
+ groupingFunction(t._1))(x => x)((x, y) => (x._1, x._2 + y._2)).values
+ }
+ def determineBufferingFunction(
+ childDataType: DataType): Option[AnyRef => _] = {
+ childDataType match {
+ case _ if UnsafeRowUtils.isBinaryStable(child.dataType) => None
+ case _ => Some(collationAwareTransform(_, childDataType))
+ }
+ }
+
determineBufferingFunction(childDataType).map(groupAndReduceBuffer).getOrElse(buffer)
+ }
+
+ private def collationAwareTransform(myData: AnyRef, myElementType:
DataType): AnyRef = {
+ if (UnsafeRowUtils.isBinaryStable(myElementType)) {
+ // Short-circuit if there is no collation.
+ myData
+ } else if (myElementType.isInstanceOf[StructType]) {
+ processStructTypeWithBuffer(
+ myData.asInstanceOf[InternalRow].toSeq(
+ myElementType.asInstanceOf[StructType]).zip(
+ myElementType.asInstanceOf[StructType].fields))
+ } else if (myElementType.isInstanceOf[ArrayType]) {
+ processArrayTypeWithBuffer(
+ myElementType.asInstanceOf[ArrayType],
+ myData.asInstanceOf[ArrayData])
+ } else if (myElementType.isInstanceOf[StringType]) {
+ CollationFactory.getCollationKey(
+ myData.asInstanceOf[UTF8String],
+ myElementType.asInstanceOf[StringType].collationId)
+ } else {
+ throw new UnsupportedOperationException(
+ s"Unsupported data type for collation-aware mode: $myElementType")
+ }
Review Comment:
can we use `match` on myElementType, instead of doing `if/else` here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
