uros-db commented on code in PR #47845:
URL: https://github.com/apache/spark/pull/47845#discussion_r1728583732
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CollationTypeCasts.scala:
##########
@@ -90,6 +90,16 @@ object CollationTypeCasts extends TypeCoercionRule {
val newValues = collateToSingleType(mapCreate.values)
mapCreate.withNewChildren(newKeys.zip(newValues).flatMap(pair =>
Seq(pair._1, pair._2)))
+ case splitPart: SplitPart =>
+ val Seq(str, delimiter, partNum) = splitPart.children
+ val Seq(newStr, newDelimiter) = collateToSingleType(Seq(str, delimiter))
+ splitPart.withNewChildren(Seq(newStr, newDelimiter, partNum))
+
+ case stringSplitSQL: StringSplitSQL =>
+ val Seq(str, delimiter) = stringSplitSQL.children
+ val Seq(newStr, newDelimiter) = collateToSingleType(Seq(str, delimiter))
+ stringSplitSQL.withNewChildren(Seq(newStr, newDelimiter))
Review Comment:
iiuc, this code is not tested at this point
`StringSplitSQL` is an internal expression, but we should still probably
test it (if there's no better place, then in `CollationStringExpressionsSuite`
- with a comment explaining why we're doing that there)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
