panbingkun commented on code in PR #47845:
URL: https://github.com/apache/spark/pull/47845#discussion_r1728876256
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CollationTypeCasts.scala:
##########
@@ -90,6 +90,16 @@ object CollationTypeCasts extends TypeCoercionRule {
val newValues = collateToSingleType(mapCreate.values)
mapCreate.withNewChildren(newKeys.zip(newValues).flatMap(pair =>
Seq(pair._1, pair._2)))
+ case splitPart: SplitPart =>
+ val Seq(str, delimiter, partNum) = splitPart.children
+ val Seq(newStr, newDelimiter) = collateToSingleType(Seq(str, delimiter))
+ splitPart.withNewChildren(Seq(newStr, newDelimiter, partNum))
+
+ case stringSplitSQL: StringSplitSQL =>
+ val Seq(str, delimiter) = stringSplitSQL.children
+ val Seq(newStr, newDelimiter) = collateToSingleType(Seq(str, delimiter))
+ stringSplitSQL.withNewChildren(Seq(newStr, newDelimiter))
Review Comment:
Because `StringSplitSQL` is an internal expression, it seems impossible to
perform `E2E SQL test`, so `CollationTypeCasts.transform` is directly called
here to test it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
