neilramaswamy commented on PR #47864: URL: https://github.com/apache/spark/pull/47864#issuecomment-2311582769
Hi @yaooqinn, thanks for the review! I'll get to them shortly. FYI for reviewers: I realized after opening this that we're going to have a bit of a tricky time with hyperlinks on the site. Currently, the URL namespace of the version-specific doc files is flat: `/structured-streaming-programming-guide.html` is a sibling to `/sql-performance-tuning.html`. Since all this content is flatly under `/docs/<version>`, the URLs on these pages can all just link to any sibling page via `foobar.html`. However, if some of these pages were under `/docs/<verson>/streaming`, they would have to do `../foobar.html`. The issue is that the navigation menu, which is inserted via a Jekyll include, doesn't currently know whether to put `foobar.html` or `../foobar.html`. In this PR, I (mistakenly) changed all the URLs to be absolute to try to elide this problem. However, `/api/... takes users to `spark.apache.org/api/...` instead of `spark.apache.org/docs/<version>/api`. So, I need to resolve this bug before we can merge this, which might take a few days to work out. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
