MaxGekk commented on code in PR #47893:
URL: https://github.com/apache/spark/pull/47893#discussion_r1734152591
##########
core/src/test/scala/org/apache/spark/benchmark/Benchmark.scala:
##########
@@ -94,9 +94,11 @@ private[spark] class Benchmark(
/**
* Runs the benchmark and outputs the results to stdout. This should be
copied and added as
* a comment with the benchmark. Although the results vary from machine to
machine, it should
- * provide some baseline.
+ * provide some baseline. If `relative_time` is set to `true`, the
`Relative` column will be
+ * the relative time of each case relative to the first case (less is
better). Otherwise, it
+ * will be the relative execution speed of each case relative to the first
case (more is better).
*/
- def run(): Unit = {
+ def run(relative_time: Boolean = false): Unit = {
Review Comment:
We follow the camelCase style in Spark, see
https://github.com/databricks/scala-style-guide?tab=readme-ov-file#naming-convention
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
