MaxGekk commented on code in PR #47893:
URL: https://github.com/apache/spark/pull/47893#discussion_r1735793232
##########
core/src/test/scala/org/apache/spark/benchmark/Benchmark.scala:
##########
@@ -116,14 +118,15 @@ private[spark] class Benchmark(
name + ":", "Best Time(ms)", "Avg Time(ms)", "Stdev(ms)", "Rate(M/s)",
"Per Row(ns)", "Relative")
Review Comment:
I believe the benchmark result should be self-readable. A reader shouldn't
consult to source code to figure out meaning of `Relative`. How about to
indicate that in the header.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
