mihailom-db commented on code in PR #47364:
URL: https://github.com/apache/spark/pull/47364#discussion_r1737962273
##########
common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationFactory.java:
##########
@@ -342,6 +358,42 @@ private static int collationNameToId(String collationName)
throws SparkException
}
protected abstract Collation buildCollation();
+
+ protected String catalog;
+ protected String schema;
Review Comment:
Let's make these fields part of Collation class, to avoid this unnecessary
calls for setCatalog and setSchema. And to make collation object contain all
the information about given collation and not get some other information from
other place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
