mihailom-db commented on code in PR #47364:
URL: https://github.com/apache/spark/pull/47364#discussion_r1738278767
##########
common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationFactory.java:
##########
@@ -341,7 +373,38 @@ private static int collationNameToId(String collationName)
throws SparkException
}
}
Review Comment:
That is true actually. I will do a bit more of testing on how we can handle
these two, as to me it seems a bit weird to only have it in meta, but not in
the Collation itself. Also I feel like if we end up having calls for catalog
and schema we need to think of the case where we add user defined collations.
Will provide update by the end of the day.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
