cloud-fan commented on code in PR #46880:
URL: https://github.com/apache/spark/pull/46880#discussion_r1741322635
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala:
##########
@@ -3332,22 +3332,35 @@ case class FormatNumber(x: Expression, d: Expression)
/**
* Splits a string into arrays of sentences, where each sentence is an array
of words.
- * The 'lang' and 'country' arguments are optional, and if omitted, the
default locale is used.
+ * The 'lang' and 'country' arguments are optional, and if they are both
omitted,
+ * the default locale (the lang is `en` and the country is `US`) is used.
*/
@ExpressionDescription(
- usage = "_FUNC_(str[, lang, country]) - Splits `str` into an array of array
of words.",
+ usage = "_FUNC_(str[, lang[, country]]) - Splits `str` into an array of
array of words.",
+ arguments = """
+ Arguments:
+ * str - A STRING expression to be parsed.
+ * lang - An optional STRING expression with a language code from ISO 639
Alpha-2 (e.g. 'DE'),
+ Alpha-3, or a language subtag of up to 8 characters.
+ * country - An optional STRING expression with a country code from ISO
3166 alpha-2 country
+ code or a UN M.49 numeric-3 area code.
+ """,
examples = """
Examples:
> SELECT _FUNC_('Hi there! Good morning.');
[["Hi","there"],["Good","morning"]]
+ > SELECT _FUNC_('Hi there! Good morning.', 'en');
+ [["Hi","there"],["Good","morning"]]
+ > SELECT _FUNC_('Hi there! Good morning.', 'en', 'US');
+ [["Hi","there"],["Good","morning"]]
""",
since = "2.0.0",
group = "string_funcs")
case class Sentences(
str: Expression,
language: Expression = Literal(""),
country: Expression = Literal(""))
- extends TernaryExpression with ImplicitCastInputTypes with CodegenFallback {
+ extends TernaryExpression with ImplicitCastInputTypes {
Review Comment:
is it possible to implement codegen by using `StaticInvoke` and
`RuntimeReplaceable`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
