cloud-fan commented on code in PR #46880:
URL: https://github.com/apache/spark/pull/46880#discussion_r1741324354
##########
sql/core/src/test/scala/org/apache/spark/sql/StringFunctionsSuite.scala:
##########
@@ -741,6 +765,18 @@ class StringFunctionsSuite extends QueryTest with
SharedSparkSession {
)
}
+ test("function sentences - Codegen Support") {
Review Comment:
we don't need such a test, as supporting codegen is very explicit. I think
passing all tests is sufficient, including the newly added result checking
tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
