HyukjinKwon commented on code in PR #47951:
URL: https://github.com/apache/spark/pull/47951#discussion_r1741617724
##########
sql/core/src/main/scala/org/apache/spark/sql/jdbc/MySQLDialect.scala:
##########
@@ -52,6 +52,15 @@ private case class MySQLDialect() extends JdbcDialect with
SQLConfHelper with No
supportedFunctions.contains(funcName)
class MySQLSQLBuilder extends JDBCSQLBuilder {
+ override def visitExtract(field: String, source: String): String = {
+ field match {
+ case "DAY_OF_YEAR" => s"DAYOFYEAR($source)"
+// case "DAY_OF_WEEK" => s"(EXTRACT(ISO_DAY_OF_WEEK FROM $source) % 7)
+ 1"
+// case "WEEK_DAY" => s"WEEKDAY($source)"
Review Comment:
Can we remove those commented changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
