cloud-fan commented on code in PR #47951: URL: https://github.com/apache/spark/pull/47951#discussion_r1750245650
########## sql/core/src/main/scala/org/apache/spark/sql/jdbc/MySQLDialect.scala: ########## @@ -46,12 +46,41 @@ private case class MySQLDialect() extends JdbcDialect with SQLConfHelper with No // See https://dev.mysql.com/doc/refman/8.0/en/aggregate-functions.html private val supportedAggregateFunctions = Set("MAX", "MIN", "SUM", "COUNT", "AVG") ++ distinctUnsupportedAggregateFunctions - private val supportedFunctions = supportedAggregateFunctions + private val supportedFunctions = supportedAggregateFunctions ++ Set("DATE_ADD", "DATE_DIFF") override def isSupportedFunction(funcName: String): Boolean = supportedFunctions.contains(funcName) class MySQLSQLBuilder extends JDBCSQLBuilder { + override def visitExtract(field: String, source: String): String = { + field match { + case "DAY_OF_YEAR" => s"DAYOFYEAR($source)" + case "YEAR_OF_WEEK" => s"EXTRACT(YEAR FROM $source)" + // WEEKDAY uses Monday = 0, Tuesday = 1, ... and ISO standard is Monday = 1, ..., + // so we use the formula (WEEKDAY + 1) to follow the ISO standard. + case "DAY_OF_WEEK" => s"(WEEKDAY($source) + 1)" + case _ => super.visitExtract(field, source) Review Comment: does MySQL really support other fields? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
