mridulm commented on code in PR #47395:
URL: https://github.com/apache/spark/pull/47395#discussion_r1742992365
##########
core/src/main/scala/org/apache/spark/HeartbeatReceiver.scala:
##########
@@ -176,13 +176,6 @@ private[spark] class HeartbeatReceiver(sc: SparkContext,
clock: Clock)
Option(self).map(_.ask[Boolean](ExecutorRegistered(executorId)))
}
- /**
- * If the heartbeat receiver is not stopped, notify it of executor
registrations.
- */
- override def onExecutorAdded(executorAdded: SparkListenerExecutorAdded):
Unit = {
- addExecutor(executorAdded.executorId)
- }
-
Review Comment:
It looks inconsistent to have scheduler call into heartbeat receiver for
execution addition and not removal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
