panbingkun commented on code in PR #47364:
URL: https://github.com/apache/spark/pull/47364#discussion_r1751117458
##########
common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationFactory.java:
##########
@@ -923,4 +1076,12 @@ public static String getClosestSuggestionsOnInvalidName(
return String.join(", ", suggestions);
}
+
+ public static List<CollationIdentifier> listCollations(String catalog,
String schema) {
+ return Collation.CollationSpec.listCollations(catalog, schema);
+ }
+
+ public static Collation loadCollation(CollationIdentifier
collationIdentifier) {
Review Comment:
Do you mean: we define as follows ?
```java
public record CollationMeta(...)
CollationMeta loadCollation(CollationIdentifier collationIdentifier)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
