mihailom-db commented on code in PR #47364:
URL: https://github.com/apache/spark/pull/47364#discussion_r1751428380
##########
common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationFactory.java:
##########
@@ -923,4 +1063,13 @@ public static String getClosestSuggestionsOnInvalidName(
return String.join(", ", suggestions);
}
+
+ public static List<CollationIdentifier> listCollations(String catalog,
String schema) {
+ return Collation.CollationSpec.listCollations(catalog, schema);
Review Comment:
Maybe we can than leave this hardcoded in buildCollationMeta to be
SYSTEM/BUILTIN until we see a need to actually use catalog and schema? I am not
sure if for example in future catalog/schema information would be included in
the name for user defined collations, so we should probably keep this simple
for now, so we do not create additional work to migrate later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
