cloud-fan commented on PR #45294: URL: https://github.com/apache/spark/pull/45294#issuecomment-2351496025
Hi all, I'm revisiting this PR and worried about the behavior change. I 100% agree that codegen and interpreted must have the same behavior, but it's arguable which behavior is more correct. For non-ANSI mode, I think the Java overflow behavior is more common in Spark. In addition, codegen behavior is more widely seen by end users and it's safer to keep the codegen behavior unchanged. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
