vladanvasi-db commented on code in PR #48121:
URL: https://github.com/apache/spark/pull/48121#discussion_r1762658921
##########
sql/api/src/main/scala/org/apache/spark/sql/internal/types/AbstractStringType.scala:
##########
@@ -51,3 +51,14 @@ case object StringTypeBinaryLcase extends AbstractStringType
{
case object StringTypeAnyCollation extends AbstractStringType {
override private[sql] def acceptsType(other: DataType): Boolean =
other.isInstanceOf[StringType]
}
+
+/**
+ * Use StringTypeNonCSAICollation for expressions supporting all possible
collation types
+ * except CS_AI collation types.
+ */
+case object StringTypeNonCSAICollation extends AbstractStringType {
+ override private[sql] def acceptsType(other: DataType): Boolean =
+ other.isInstanceOf[StringType] &&
+ (!other.asInstanceOf[StringType].typeName.contains("_AI") ||
+ other.asInstanceOf[StringType].typeName.contains("_CI"))
Review Comment:
Yes, but this also includes the case that the collator has only `_AI` suffix
and also we want to allow `CI_AI` collators for these expressions as they are
behaving correctly. Also, the modifier may be written like `AI_CS` or just
`_AI` like in the PR description example.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
