uros-db commented on code in PR #48121:
URL: https://github.com/apache/spark/pull/48121#discussion_r1764760993
##########
sql/api/src/main/scala/org/apache/spark/sql/types/StringType.scala:
##########
@@ -44,6 +44,9 @@ class StringType private (val collationId: Int) extends
AtomicType with Serializ
private[sql] def supportsLowercaseEquality: Boolean =
CollationFactory.fetchCollation(collationId).supportsLowercaseEquality
+ private[sql] def isNonCSAICollation: Boolean =
+ !CollationFactory.isAI(collationId) || CollationFactory.isCI(collationId)
Review Comment:
this is starting to look very confusing at this point - I would avoid adding
this to `StringType`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]