uros-db commented on code in PR #48222:
URL: https://github.com/apache/spark/pull/48222#discussion_r1775469040
##########
common/unsafe/src/test/scala/org/apache/spark/unsafe/types/CollationFactorySuite.scala:
##########
@@ -369,8 +369,6 @@ class CollationFactorySuite extends AnyFunSuite with
Matchers { // scalastyle:ig
1 << 15, // UTF8_BINARY mandatory zero bit 15 breach.
1 << 16, // UTF8_BINARY mandatory zero bit 16 breach.
1 << 17, // UTF8_BINARY mandatory zero bit 17 breach.
- 1 << 18, // UTF8_BINARY mandatory zero bit 18 breach.
- 1 << 19, // UTF8_BINARY mandatory zero bit 19 breach.
Review Comment:
and what about bit 20? do we still keep it as mandatory zero
also, what about bit 21? I don't even see that one here...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
