uros-db commented on code in PR #48222:
URL: https://github.com/apache/spark/pull/48222#discussion_r1775441674
##########
sql/core/src/test/scala/org/apache/spark/sql/CollationSuite.scala:
##########
@@ -44,27 +44,57 @@ class CollationSuite extends DatasourceV2SQLBase with
AdaptiveSparkPlanHelper {
private val allFileBasedDataSources = collationPreservingSources ++
collationNonPreservingSources
test("collate returns proper type") {
- Seq("utf8_binary", "utf8_lcase", "unicode", "unicode_ci").foreach {
collationName =>
+ Seq(
+ "utf8_binary",
+ "utf8_lcase",
+ "unicode",
+ "unicode_ci",
+ "unicode_ltrim_ci",
+ "utf8_lcase_trim",
+ "utf8_binary_rtrim"
+ ).foreach { collationName =>
checkAnswer(sql(s"select 'aaa' collate $collationName"), Row("aaa"))
val collationId = CollationFactory.collationNameToId(collationName)
- assert(sql(s"select 'aaa' collate $collationName").schema(0).dataType
- == StringType(collationId))
+ assert(
+ sql(s"select 'aaa' collate $collationName").schema(0).dataType
+ == StringType(collationId)
+ )
}
}
test("collation name is case insensitive") {
- Seq("uTf8_BiNaRy", "utf8_lcase", "uNicOde", "UNICODE_ci").foreach {
collationName =>
+ Seq(
+ "uTf8_BiNaRy",
+ "utf8_lcase",
+ "uNicOde",
+ "UNICODE_ci",
+ "uNiCoDE_ltRIm_cI",
+ "UtF8_lCaSE_tRIM",
+ "utf8_biNAry_RtRiM"
+ ).foreach { collationName =>
checkAnswer(sql(s"select 'aaa' collate $collationName"), Row("aaa"))
val collationId = CollationFactory.collationNameToId(collationName)
- assert(sql(s"select 'aaa' collate $collationName").schema(0).dataType
- == StringType(collationId))
+ assert(
+ sql(s"select 'aaa' collate $collationName").schema(0).dataType
+ == StringType(collationId)
+ )
}
}
test("collation expression returns name of collation") {
- Seq("utf8_binary", "utf8_lcase", "unicode", "unicode_ci").foreach {
collationName =>
Review Comment:
top avoid repetition across tests, let's consider using something like
`testSuppCollations`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
