siying commented on code in PR #47932:
URL: https://github.com/apache/spark/pull/47932#discussion_r1794316670
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/CommitLog.scala:
##########
@@ -72,12 +74,37 @@ class CommitLog(sparkSession: SparkSession, path: String)
}
object CommitLog {
- private val VERSION = 1
+ private val VERSION = SQLConf.get.stateStoreCheckpointFormatVersion
Review Comment:
Why do we need to change this version?
##########
sql/core/src/test/scala/org/apache/spark/sql/streaming/resources/testCommitLogV1/testCommitLog:
##########
@@ -0,0 +1,2 @@
+v1
+{"nextBatchWatermarkMs":1,"stateUniqueIds":{}}
Review Comment:
It's better to put it as a constant string in the source code and write it
in a file when the tests start. I am not sure we can always assume that when
the test runs, we can access to the source code files. It is less flexible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
