brkyvz commented on code in PR #47932:
URL: https://github.com/apache/spark/pull/47932#discussion_r1809594502


##########
sql/core/src/test/scala/org/apache/spark/sql/streaming/resources/testCommitLogV1/testCommitLog:
##########
@@ -0,0 +1,2 @@
+v1
+{"nextBatchWatermarkMs":1,"stateUniqueIds":{}}

Review Comment:
   ah my bad - was worried when I didn't see a golden file for it. Any reason 
you haven't created a golden file? Then you may not need to expose the methods 
inside CommitLog?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to