uros-db commented on code in PR #48386:
URL: https://github.com/apache/spark/pull/48386#discussion_r1798971497
##########
common/unsafe/src/test/scala/org/apache/spark/unsafe/types/CollationFactorySuite.scala:
##########
@@ -162,19 +166,32 @@ class CollationFactorySuite extends AnyFunSuite with
Matchers { // scalastyle:ig
CollationTestCase("UTF8_BINARY", "aaa", "AAA", 1),
CollationTestCase("UTF8_BINARY", "aaa", "bbb", -1),
CollationTestCase("UTF8_BINARY", "aaa", "BBB", 1),
+ CollationTestCase("UTF8_BINARY_RTRIM", "aaa ", "aaa", 0),
+ CollationTestCase("UTF8_BINARY_RTRIM", "aaa ", "bbb", -1),
+ CollationTestCase("UTF8_BINARY_RTRIM", "aaa", "BBB" , 1),
CollationTestCase("UTF8_LCASE", "aaa", "aaa", 0),
CollationTestCase("UTF8_LCASE", "aaa", "AAA", 0),
CollationTestCase("UTF8_LCASE", "aaa", "AaA", 0),
CollationTestCase("UTF8_LCASE", "aaa", "AaA", 0),
CollationTestCase("UTF8_LCASE", "aaa", "aa", 1),
CollationTestCase("UTF8_LCASE", "aaa", "bbb", -1),
+ CollationTestCase("UTF8_LCASE_RTRIM", "aaa ", "AAA", 0),
+ CollationTestCase("UTF8_LCASE_RTRIM", "aaa", "bbb ", -1),
+ CollationTestCase("UTF8_LCASE_RTRIM", "aaa ", "aa", 1),
CollationTestCase("UNICODE", "aaa", "aaa", 0),
CollationTestCase("UNICODE", "aaa", "AAA", -1),
CollationTestCase("UNICODE", "aaa", "bbb", -1),
CollationTestCase("UNICODE", "aaa", "BBB", -1),
+ CollationTestCase("UNICODE_RTRIM", "aaa ", "aaa ", 0),
+ CollationTestCase("UNICODE_RTRIM", "aaa", "AAA ", -1),
+ CollationTestCase("UNICODE_RTRIM", "aaa ", "bbb ", -1),
CollationTestCase("UNICODE_CI", "aaa", "aaa", 0),
CollationTestCase("UNICODE_CI", "aaa", "AAA", 0),
- CollationTestCase("UNICODE_CI", "aaa", "bbb", -1))
+ CollationTestCase("UNICODE_CI", "aaa", "bbb", -1),
+ CollationTestCase("UNICODE_CI_RTRIM", "aaa", "aaa ", 0),
+ CollationTestCase("UNICODE_CI_RTRIM", "aaa ", "AAA", 0),
+ CollationTestCase("UNICODE_CI_RTRIM", "aaa ", "bbb ", -1)
Review Comment:
and of course same goes here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
