uros-db commented on code in PR #48386:
URL: https://github.com/apache/spark/pull/48386#discussion_r1798979827
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/hash.scala:
##########
@@ -566,7 +566,7 @@ abstract class InterpretedHashFunction {
hashUnsafeBytes(a, Platform.BYTE_ARRAY_OFFSET, a.length, seed)
case s: UTF8String =>
val st = dataType.asInstanceOf[StringType]
- if (st.supportsBinaryEquality) {
+ if (st.supportsBinaryEquality && !st.usesTrimCollation) {
Review Comment:
on another note, let's make sure that we reconsider this in the follow-up:
https://issues.apache.org/jira/browse/SPARK-49911
please add `// TODO(SPARK-49911)` comments wherever appropriate, just so
that we don't miss it
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/hash.scala:
##########
@@ -817,7 +817,7 @@ case class HiveHash(children: Seq[Expression]) extends
HashExpression[Int] {
override protected def genHashString(
ctx: CodegenContext, stringType: StringType, input: String, result:
String): String = {
- if (stringType.supportsBinaryEquality) {
+ if (stringType.supportsBinaryEquality && !stringType.usesTrimCollation) {
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
