mihailom-db commented on code in PR #48500:
URL: https://github.com/apache/spark/pull/48500#discussion_r1803390028
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryExecutionErrors.scala:
##########
@@ -362,12 +362,11 @@ private[sql] object QueryExecutionErrors extends
QueryErrorsBase with ExecutionE
"groupIndex" -> groupIndex.toString()))
}
- def invalidUrlError(url: UTF8String, e: URISyntaxException):
SparkIllegalArgumentException = {
+ def invalidUrlError(url: UTF8String, e: URISyntaxException)
+ : SparkIllegalArgumentException = {
Review Comment:
nit: Please fix this change in style, as it is not necessary.
##########
common/utils/src/main/resources/error/error-conditions.json:
##########
@@ -3207,7 +3207,7 @@
},
"INVALID_URL" : {
"message" : [
- "The url is invalid: <url>. If necessary set <ansiConfig> to \"false\"
to bypass this error."
+ "The url is invalid: <url>. Use try_parse_url to tolerate invalid URL
and return NULL instead."
Review Comment:
Please add quotes to the function name, see some other errors. This is just
to keep it in the same state.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
