MaxGekk commented on code in PR #48500:
URL: https://github.com/apache/spark/pull/48500#discussion_r1809160987
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/urlExpressions.scala:
##########
@@ -169,6 +169,37 @@ object ParseUrl {
private val REGEXSUBFIX = "=([^&]*)"
}
+/**
+ * Extracts a part from a URL
Review Comment:
This comment is useless. Let's remove it.
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/urlExpressions.scala:
##########
@@ -169,6 +169,37 @@ object ParseUrl {
private val REGEXSUBFIX = "=([^&]*)"
}
+/**
+ * Extracts a part from a URL
+ */
+@ExpressionDescription(
+ usage = "_FUNC_(url, partToExtract[, key]) - Extracts a part from a URL.",
Review Comment:
`ParseUrl` has the same description. Could write a few words what destiguish
new expression from `ParseUrl`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
