micheal-o commented on code in PR #47875:
URL: https://github.com/apache/spark/pull/47875#discussion_r1803892272
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/RocksDBSuite.scala:
##########
@@ -896,8 +898,10 @@ class RocksDBSuite extends
AlsoTestWithChangelogCheckpointingEnabled with Shared
// that checkpoint the same version of state
val fileManager = new RocksDBFileManager(
dfsRootDir, Utils.createTempDir(), new Configuration)
+ val rocksDBFileMapping = new RocksDBFileMapping()
val fileManager_ = new RocksDBFileManager(
dfsRootDir, Utils.createTempDir(), new Configuration)
+ val rocksDBFileMapping_ = new RocksDBFileMapping()
Review Comment:
removed, not used
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDBFileManager.scala:
##########
@@ -146,33 +145,13 @@ class RocksDBFileManager(
private def codec = CompressionCodec.createCodec(sparkConf, codecName)
+ // This is set when a version is loaded/committed. Hence only set by a query
thread.
Review Comment:
done
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDB.scala:
##########
@@ -902,7 +893,6 @@ class RocksDB(
def isAcquiredByDifferentThread = acquiredThreadInfo != null &&
acquiredThreadInfo.threadRef.get.isDefined &&
newAcquiredThreadInfo.threadRef.get.get.getId !=
acquiredThreadInfo.threadRef.get.get.getId
-
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
