micheal-o commented on code in PR #47875:
URL: https://github.com/apache/spark/pull/47875#discussion_r1803892889
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDB.scala:
##########
@@ -644,21 +632,40 @@ class RocksDB(
// If we have changed the columnFamilyId mapping, we have set a new
// snapshot and need to upload this to the DFS even if changelog
checkpointing
// is enabled.
+ var isUploaded = false
if (shouldForceSnapshot.get()) {
- uploadSnapshot()
+ assert(snapshot.isDefined)
+ fileManagerMetrics = uploadSnapshot(
+ snapshot.get,
+ fileManager,
+ rocksDBFileMapping.snapshotsPendingUpload,
+ loggingId
+ )
+ isUploaded = true
shouldForceSnapshot.set(false)
}
// ensure that changelog files are always written
try {
assert(changelogWriter.isDefined)
changelogWriter.foreach(_.commit())
+ if (!isUploaded) {
+ snapshot.foreach(s => {
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
