uros-db commented on code in PR #48608:
URL: https://github.com/apache/spark/pull/48608#discussion_r1812034802
##########
sql/core/src/test/scala/org/apache/spark/sql/CollationSQLExpressionsSuite.scala:
##########
@@ -2435,99 +2447,105 @@ class CollationSQLExpressionsSuite
}
test("min_by supports collation") {
- val collation = "UNICODE"
- val query = s"SELECT min_by(x, y) FROM VALUES ('a', 10), ('b', 50), ('c',
20) AS tab(x, y);"
- withSQLConf(SqlApiConf.DEFAULT_COLLATION -> collation) {
- checkAnswer(
- sql(query),
- Seq(
- Row("a")
+ Seq("UNICODE", "SR", "SR_CI", "SR_AI", "SR_CI_AI").foreach(collation => {
Review Comment:
if we're re-using this exact collation list across multiple tests within the
suite, let's separate it out
please see `CollationSupportSuite` for example:
```
private final String[] testSupportedCollations =
{"UTF8_BINARY", "UTF8_LCASE", "UNICODE", "UNICODE_CI"};
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
