dejankrak-db commented on PR #48608: URL: https://github.com/apache/spark/pull/48608#issuecomment-2431715267
> let's add more tests > > * `CollationSupportSuite` is the place to really knock yourself out with fresh, new, interesting examples - no need to be shy there, given that those unit tests are quite cheap to execute > * `CollationSuite` there are many important tests here, including join-related tests, so let's make sure to cover them as best as we can > * `CollationExpressionSuite` let's add new test cases here as well > * `CollationFactorySuite` let's add new test cases here as well > * `collations.sql` let's add many, new cool test cases here as well Sure, will add these tests in subsequent iterations! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
