MaxGekk commented on code in PR #48598:
URL: https://github.com/apache/spark/pull/48598#discussion_r1812542404
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala:
##########
@@ -767,6 +777,35 @@ case class InSet(child: Expression, hset: Set[Any])
extends UnaryExpression with
override protected def withNewChildInternal(newChild: Expression): InSet =
copy(child = newChild)
}
+object InSet {
Review Comment:
> since these classes seem pretty general
hmm why? So far the classes are pretty specific to `InSet`. I didn't get why
do you want to make them too generic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
