stefankandic commented on code in PR #48598:
URL: https://github.com/apache/spark/pull/48598#discussion_r1812596783
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala:
##########
@@ -767,6 +777,35 @@ case class InSet(child: Expression, hset: Set[Any])
extends UnaryExpression with
override protected def withNewChildInternal(newChild: Expression): InSet =
copy(child = newChild)
}
+object InSet {
Review Comment:
I wouldn't agree that they are specific only to `InSet`, at least in my mind
they are just collation aware implementations of the scala's set interface; so
they can (and probably will) be used by someone other than `InSet`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
