cloud-fan commented on code in PR #48436:
URL: https://github.com/apache/spark/pull/48436#discussion_r1814393415
##########
sql/api/src/main/scala/org/apache/spark/sql/catalyst/parser/DataTypeAstBuilder.scala:
##########
@@ -76,7 +76,7 @@ class DataTypeAstBuilder extends
SqlBaseParserBaseVisitor[AnyRef] {
case (TIMESTAMP_LTZ, Nil) => TimestampType
case (STRING, Nil) =>
typeCtx.children.asScala.toSeq match {
- case Seq(_) => SqlApiConf.get.defaultStringType
+ case Seq(_) => DefaultStringType()
Review Comment:
My proposal: since we need to distinguish between default string type and
explicit collated string type, we should let the caller side tell us if they
want to annotate the default string type. We can add a new flag
```
override def visitPrimitiveDataType(ctx: PrimitiveDataTypeContext): DataType
=
visitPrimitiveDataTypeImpl(ctx, false)
def visitPrimitiveDataTypeImpl(ctx: PrimitiveDataTypeContext,
annotateDefaultStringType: Boolean): DataType
```
In the parser rules of DDL commands, we invoke `visitPrimitiveDataTypeImpl`
with `annotateDefaultStringType` set to true.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
