stefankandic commented on code in PR #48436:
URL: https://github.com/apache/spark/pull/48436#discussion_r1814739407
##########
sql/api/src/main/scala/org/apache/spark/sql/catalyst/parser/DataTypeAstBuilder.scala:
##########
@@ -76,7 +76,7 @@ class DataTypeAstBuilder extends
SqlBaseParserBaseVisitor[AnyRef] {
case (TIMESTAMP_LTZ, Nil) => TimestampType
case (STRING, Nil) =>
typeCtx.children.asScala.toSeq match {
- case Seq(_) => SqlApiConf.get.defaultStringType
+ case Seq(_) => DefaultStringType()
Review Comment:
Is it a breaking change even though the `DefaultStringType() == StringType`
will still yield true? It's really just a wrapper with exactly the same
functionality and semantics
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
