anishshri-db commented on code in PR #48401:
URL: https://github.com/apache/spark/pull/48401#discussion_r1815762027
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/ValueStateImplWithTTL.scala:
##########
@@ -44,11 +44,12 @@ class ValueStateImplWithTTL[S](
valEncoder: Encoder[S],
ttlConfig: TTLConfig,
batchTimestampMs: Long,
+ avroSerde: Option[AvroSerde],
metrics: Map[String, SQLMetric] = Map.empty)
extends SingleKeyTTLStateImpl(
stateName, store, keyExprEnc, batchTimestampMs) with ValueState[S] {
- private val stateTypesEncoder = StateTypesEncoder(keyExprEnc, valEncoder,
+ private val stateTypesEncoder = UnsafeRowTypesEncoder(keyExprEnc, valEncoder,
Review Comment:
lets just comment that avro is not supported in TTL yet
maybe better to even fail the query explicitly for now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
