anishshri-db commented on code in PR #48401:
URL: https://github.com/apache/spark/pull/48401#discussion_r1815765016
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/StateStore.scala:
##########
@@ -163,6 +219,9 @@ trait StateStore extends ReadStateStore {
def merge(key: UnsafeRow, value: UnsafeRow,
colFamilyName: String = StateStore.DEFAULT_COL_FAMILY_NAME): Unit
+ def merge(key: Array[Byte], value: Array[Byte], colFamilyName: String): Unit
+
+
Review Comment:
nit: extra newline
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/StateStore.scala:
##########
@@ -153,6 +192,23 @@ trait StateStore extends ReadStateStore {
key: UnsafeRow,
colFamilyName: String = StateStore.DEFAULT_COL_FAMILY_NAME): Unit
+ /**
+ * Put a new non-null value for a non-null key. Implementations must be
aware that the UnsafeRows
+ * in the params can be reused, and must make copies of the data as needed
for persistence.
+ */
+ def put(
+ key: Array[Byte],
+ value: Array[Byte],
+ colFamilyName: String): Unit
+
+ /**
+ * Remove a single non-null key.
+ */
+ def remove(
+ key: Array[Byte],
+ colFamilyName: String): Unit
+
+
Review Comment:
nit: extra newline
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
