xupefei commented on code in PR #48120:
URL: https://github.com/apache/spark/pull/48120#discussion_r1831091471
##########
sql/core/src/main/scala/org/apache/spark/sql/artifact/ArtifactManager.scala:
##########
@@ -68,18 +69,43 @@ class ArtifactManager(session: SparkSession) extends
Logging {
s"$artifactRootURI${File.separator}${session.sessionUUID}")
// The base directory/URI where all class file artifacts are stored for this
`sessionUUID`.
- protected[artifact] val (classDir, classURI): (Path, String) =
+ protected[artifact] val (classDir, replClassURI): (Path, String) =
(ArtifactUtils.concatenatePaths(artifactPath, "classes"),
s"$artifactURI${File.separator}classes${File.separator}")
- protected[artifact] val state: JobArtifactState =
- JobArtifactState(session.sessionUUID, Option(classURI))
+ private lazy val alwaysApplyClassLoader =
+
session.conf.get(SQLConf.ARTIFACTS_SESSION_ISOLATION_ALWAYS_APPLY_CLASSLOADER.key).toBoolean
- def withResources[T](f: => T): T = {
- Utils.withContextClassLoader(classloader) {
- JobArtifactSet.withActiveJobArtifactState(state) {
+ private lazy val sessionIsolated =
+ session.conf.get(SQLConf.ARTIFACTS_SESSION_ISOLATION_ENABLED.key).toBoolean
Review Comment:
Done! I rephased the doc to
```
.doc("When enabled for a Spark Session, artifacts (such as JARs, files,
archives) added to " +
"this session are isolated from other sessions within the same Spark
instance. When " +
"disabled for a session, artifacts added to this session are visible to
other sessions " +
"that have this config disabled. This config can only be set during the
creation of a " +
"Spark Session and will have no effect when changed in the middle of
session usage.")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
